Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency class-validator to v0.14.0 [security] #1968

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 13, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change Age Adoption Passing Confidence
class-validator 0.13.2 -> 0.14.0 age adoption passing confidence
class-validator dependencies minor 0.13.2 -> 0.14.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2019-18413

In TypeStack class-validator, validate() input validation can be bypassed because certain internal attributes can be overwritten via a conflicting name. Even though there is an optional forbidUnknownValues parameter that can be used to reduce the risk of this bypass, this option is not documented and thus most developers configure input validation in the vulnerable default manner. With this vulnerability, attackers can launch SQL Injection or XSS attacks by injecting arbitrary malicious input.

The default settings for forbidUnknownValues has been changed to true in 0.14.0.

NOTE: a software maintainer agrees with the "is not documented" finding but suggests that much of the responsibility for the risk lies in a different product.


Release Notes

typestack/class-validator

v0.14.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from fuxingloh as a code owner January 13, 2023 01:22
@github-actions github-actions bot added area/apps kind/chore Non feature change labels Jan 13, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 13, 2023

Code Climate has analyzed commit 9b96e9e and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 9b96e9e
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63cf80b14c1fe80009949820
😎 Deploy Preview https://deploy-preview-1968--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 93.66% // Head: 93.86% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (9b96e9e) compared to base (4477778).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
+ Coverage   93.66%   93.86%   +0.20%     
==========================================
  Files         366      366              
  Lines       10979    10985       +6     
  Branches     1431     1432       +1     
==========================================
+ Hits        10283    10311      +28     
+ Misses        668      645      -23     
- Partials       28       29       +1     
Impacted Files Coverage Δ
...ps/playground-api/src/controllers/RpcController.ts 100.00% <100.00%> (ø)
apps/whale-api/src/module.api/rpc.controller.ts 91.17% <100.00%> (+0.55%) ⬆️
packages/jellyfish-address/src/p2wsh.ts 48.27% <0.00%> (-51.73%) ⬇️
apps/whale-api/src/module.api/subsidy.ts 66.66% <0.00%> (-25.00%) ⬇️
...ellyfish-transaction/src/script/dftx/dftx_token.ts 80.70% <0.00%> (-19.30%) ⬇️
...h-transaction-builder/src/txn/txn_builder_loans.ts 88.57% <0.00%> (-5.72%) ⬇️
...whale-api/src/module.indexer/rpc.block.provider.ts 89.28% <0.00%> (-2.39%) ⬇️
packages/jellyfish-api-jsonrpc/src/index.ts 97.67% <0.00%> (-2.33%) ⬇️
...ages/jellyfish-transaction/src/script/dftx/dftx.ts 97.16% <0.00%> (-1.42%) ⬇️
...ckages/jellyfish-transaction/src/script/mapping.ts 96.81% <0.00%> (-1.28%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@renovate renovate bot force-pushed the renovate/npm-class-validator-vulnerability branch from d080441 to 6bf4916 Compare January 24, 2023 03:57
@renovate renovate bot force-pushed the renovate/npm-class-validator-vulnerability branch from 6bf4916 to d26da3c Compare January 24, 2023 04:05
@renovate
Copy link
Contributor Author

renovate bot commented Jan 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@github-actions
Copy link

github-actions bot commented Jan 24, 2023

Docker build preview for jellyfish/apps is ready!

Built with commit 5803ddf

  • ghcr.io/jellyfishsdk/legacy-api:pr-1968
  • ghcr.io/jellyfishsdk/playground-api:pr-1968
  • ghcr.io/jellyfishsdk/status-api:pr-1968
  • ghcr.io/jellyfishsdk/whale-api:pr-1968

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:5803ddf14a110b9d10db19bbff441bd468e6eab3
  • ghcr.io/jellyfishsdk/playground-api:5803ddf14a110b9d10db19bbff441bd468e6eab3
  • ghcr.io/jellyfishsdk/status-api:5803ddf14a110b9d10db19bbff441bd468e6eab3
  • ghcr.io/jellyfishsdk/whale-api:5803ddf14a110b9d10db19bbff441bd468e6eab3

eli-lim
eli-lim previously approved these changes Jan 24, 2023
apps/playground-api/src/controllers/RpcController.ts Outdated Show resolved Hide resolved
@fuxingloh fuxingloh merged commit 19011fd into main Jan 24, 2023
@fuxingloh fuxingloh deleted the renovate/npm-class-validator-vulnerability branch January 24, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants